Skip to content

fix(handoff): warn on near-miss section headings - #558

Merged
solomonneas merged 2 commits into
mainfrom
fix/handoff-lint-heading-leniency
Jul 26, 2026
Merged

fix(handoff): warn on near-miss section headings#558
solomonneas merged 2 commits into
mainfrom
fix/handoff-lint-heading-leniency

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • classify reviewed homegrown headings, case variants, and punctuation variants as fixable lint warnings
  • add targeted migration hints for each noncanonical heading and for section order
  • preserve clean output for canonical notes and hard failures for malformed notes

Before

handoff lint: /tmp/brigade-handoff-heading-repro-20260726
files: 1
[fail] /tmp/brigade-handoff-heading-repro-20260726/.claude/memory-handoffs/homegrown.md (no-card)
  - missing required section: Type
  - missing required section: Title
  - missing required section: Summary

The ingest parser extracted no-card from the same file, and brigade ingest --dry-run --route-documents completed with exit 0.

After

handoff lint: /tmp/brigade-handoff-heading-repro-20260726
files: 1
[ok] /tmp/brigade-handoff-heading-repro-20260726/.claude/memory-handoffs/homegrown.md (no-card)
  hint: use ## Type instead of ## Category
  hint: use ## Title instead of ## Subject
  hint: use ## Summary instead of ## What changed
  warning: noncanonical section heading 'Category'; use ## Type
  warning: noncanonical section heading 'Subject'; use ## Title
  warning: noncanonical section heading 'What changed'; use ## Summary

Verification

brigade work verify run --target . --command "./scripts/verify" --capture brigade-work --no-reuse

  • receipt: 20260726-210606-work-verify-757d55
  • 4,309 passed, 3 skipped
  • total coverage: 82.81%

Closes #553

solomonneas and others added 2 commits July 26, 2026 17:02
Handoff lint rejects structurally sound notes that use Category, Subject,
and What changed while ingest still parses the no-card routing action.

Co-authored-by: Cursor <cursoragent@cursor.com>
Parsable homegrown and synonym headings resolve through the lint path with per-heading warnings and targeted migration hints. Reordered sections warn with the canonical order, while exact canonical notes stay clean and garbage still fails.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5016bf33-b71d-4ea1-90b5-b02bacba1f27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/handoff-lint-heading-leniency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 26, 2026
@solomonneas
solomonneas merged commit 984a9fb into main Jul 26, 2026
28 checks passed
@solomonneas
solomonneas deleted the fix/handoff-lint-heading-leniency branch July 26, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handoff lint: exact section headings required, so well-formed homegrown notes fail identically to garbage

1 participant